From d87d52248dc7d18ac27529fa5ea803a23126f0f0 Mon Sep 17 00:00:00 2001 From: Chris Brand Date: Thu, 10 Sep 2015 11:56:29 -0700 Subject: [PATCH] xen: arm: Be explicit about bit values in mfn_to_xen_entry() Ensure that every relevant bit is given an explicit value. This has no effect on the generated code, but makes it a little easier to follow. Reported-by: Julien Grall Signed-off-by: Chris Brand Acked-by: Ian Campbell --- xen/include/asm-arm/page.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/xen/include/asm-arm/page.h b/xen/include/asm-arm/page.h index 01628f3e96..a94e978a99 100644 --- a/xen/include/asm-arm/page.h +++ b/xen/include/asm-arm/page.h @@ -202,9 +202,12 @@ static inline lpae_t mfn_to_xen_entry(unsigned long mfn, unsigned attr) .ai = attr, .ns = 1, /* Hyp mode is in the non-secure world */ .user = 1, /* See below */ + .ro = 0, /* Assume read-write */ .af = 1, /* No need for access tracking */ .ng = 1, /* Makes TLB flushes easier */ + .contig = 0, /* Assume non-contiguous */ .xn = 1, /* No need to execute outside .text */ + .avail = 0, /* Reference count for domheap mapping */ }};; /* Setting the User bit is strange, but the ATS1H[RW] instructions * don't seem to work otherwise, and since we never run on Xen -- 2.30.2